-
Notifications
You must be signed in to change notification settings - Fork 490
Switch repo to Django Commons #1429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1429 +/- ##
==========================================
+ Coverage 96.87% 96.95% +0.08%
==========================================
Files 24 24
Lines 1470 1479 +9
Branches 240 189 -51
==========================================
+ Hits 1424 1434 +10
Misses 25 25
+ Partials 21 20 -1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright, let's get this merged :)
@tim-schilling I'm assuming that we should incorporate the changes of django-commons/best-practices@bed66ed, which was made after this PR was opened?
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. ℹ️ You can also turn on project coverage checks and project coverage reporting on Pull Request comment Thanks for integrating Codecov - We've got you covered ☂️ |
This uses the PyPI GitHub trusted publisher integration.
Co-authored-by: Anders <6058745+ddabble@users.noreply.github.com>
I'm going to drop the test pypi part of this. I don't think we have that setup. |
abf29b2
to
6990415
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Niice 😄
Description
Related Issue
This is in preparation for django-commons/membership#131
Motivation and Context
See #1391
Types of changes
Checklist:
pre-commit run
command to format and lint.AUTHORS.rst
CHANGES.rst
This is a WIP