Fix update_change_reason
: fails to fetch latest history entry for nullable fields
#1476
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
update_change_reason
method inutils.py
fails to update change reason in case any field is nullable in a model or is set to default toNone
. This could be due to the way django handles null values, as direct comparison to None is not allowed when filtering.Related Issue
#1475
Motivation and Context
Encountered this issue when dealing with a model with nullable fields in one of my projects
How Has This Been Tested?
Has been tested both within my project environment via test cases simulating this scenario, also tested within the suite by adding a new similar test case.
Screenshots (if appropriate):
Types of changes
Checklist:
pre-commit run
command to format and lint.AUTHORS.rst
CHANGES.rst