Skip to content

Exclude tests from wheels #1478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 16, 2025
Merged

Conversation

stefan6419846
Copy link
Contributor

Description

The wheels currently bundle all tests, which just bloats them and usually is of no value for the actual library usage.

Related Issue

Closes #1477.

Motivation and Context

Bundling tests inside wheels is uncommon and just increases the distribution size.

How Has This Been Tested?

Built the package locally using PIP_INDEX_URL=https://pypi.org/simple python -m build . and verified manually that the generated source distribution and wheel file have the expected directories.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have run the pre-commit run command to format and lint.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have added my name and/or github handle to AUTHORS.rst
  • I have added my change to CHANGES.rst
  • All new and existing tests passed.

Copy link
Member

@ddabble ddabble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks! 😊

@ddabble ddabble merged commit f69dd4f into django-commons:master Apr 16, 2025
22 checks passed
ddabble added a commit that referenced this pull request Apr 16, 2025
Forgot to do it in that PR :)
ddabble added a commit that referenced this pull request Apr 16, 2025
Forgot to do it in that PR :)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Avoid bundling tests in wheels
2 participants