[FIX] -- admin site queue choices now use user-defined settings instead of hardcoded values. #282
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ad of hardcoded values. - Fixes issue django-commons#278. - Replaces static choices like "default", "low", and "high" with dynamic values from RQ_QUEUES or SCHEDULER_QUEUES. - Keeps the admin UI consistent with project-specific configuration.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: Issue #278
This PR resolves a bug present in versions
v1.3.3andv1.3.4ofdjango-tasks-scheduler.🛠️ What’s Fixed
The queue choices in the Django admin task creation form are now loaded dynamically from user-defined settings (
RQ_QUEUESorSCHEDULER_QUEUES), instead of using hardcoded values like"default","low", and"high".✅ Working Screenshot
You can view the fix at:
/admin/scheduler/crontask/add//admin/scheduler/repeatabletask/add//admin/scheduler/scheduledtask/add/If a user attempts to submit a value that isn’t defined in their settings, a validation error will appear.
🧪 Queue Execution Confirmation
The task scheduled under the
"alerts"queue was successfully picked up and executed by the respective worker, confirming that dynamic queue selection is functioning as expected.📌 What’s Next After This PR Is Merged
pyproject.tomlversion (e.g.1.3.5) and updateREADME.mdif necessaryv1.3.5v1.3.5