victorjonsson#328 - Required fields validation message. Unit test for new feature and fixed previous.

Author: Igloczek

form-validator/jquery.form-validator.js

@@ -1027,7 +1027,12 @@
               if (!validationErrorMsg) {
                 validationErrorMsg = $elem.attr(conf.validationErrorMsgAttribute);
                 if (!validationErrorMsg) {
-                  validationErrorMsg = language[validator.errorMessageKey];
+                  if(typeof validator.errorMessageKey !== 'function') {
+                    validationErrorMsg = language[validator.errorMessageKey];
+                  }
+                  else {
+                    validationErrorMsg = language[validator.errorMessageKey(conf)];
+                  }
                   if (!validationErrorMsg) {
                     validationErrorMsg = validator.errorMessage;
                   }
@@ -1449,6 +1454,7 @@
      */
     LANG: {
       errorTitle: 'Form submission failed!',
+      requiredField: 'This field is required',
       requiredFields: 'You have not answered all required fields',
       badTime: 'You have not given a correct time',
       badEmail: 'You have not given a correct e-mail address',
@@ -1565,7 +1571,14 @@
       }
     },
     errorMessage: '',
-    errorMessageKey: 'requiredFields'
+    errorMessageKey: function(config) {
+      if (config.errorMessagePosition === 'top' || config.errorMessagePosition === 'custom') {
+        return 'requiredFields';
+      }
+      else {
+        return 'requiredField';
+      }
+    }
   });
 
   /*

test/qunit.html

@@ -175,18 +175,25 @@
          * Test error message
          */
         test('Error messages', function() {
-            var $input = input('', {'':'required'}),
+
+            // default inline (below input) error messages
+            var $input = input('', 'required'),
                 result = $.formUtils.validateInput($input, $.formUtils.LANG, $.formUtils.defaultConfig(), $form);
+            equal(result.errorMsg, 'This field is required', 'Incorrect message');
 
-            equal('You have not answered all required fields', result.errorMsg, 'Incorrect message');
+            // messages on top of form
+            var configWithTopMsg = $.formUtils.defaultConfig();
+            configWithTopMsg.errorMessagePosition = "top";
+            result = $.formUtils.validateInput($input, $.formUtils.LANG, configWithTopMsg, $form);
+            equal(result.errorMsg, 'You have not answered all required fields', 'Incorrect message');
 
             $input = input('--', {'':'required alphanumeric', 'error-msg-alphanumeric':'custom for alphanum'}),
             result = $.formUtils.validateInput($input, $.formUtils.LANG, $.formUtils.defaultConfig(), $form);
-            equal('custom for alphanum', result.errorMsg, 'Incorrect message');
+            equal(result.errorMsg, 'custom for alphanum', 'Incorrect message');
 
             $input = input('sam', {'':'required alphanumeric length', length:'min10', 'error-msg-alphanumeric':'custom for alphanum'}),
             result = $.formUtils.validateInput($input, $.formUtils.LANG, $.formUtils.defaultConfig(), $form);
-            equal('The input value is shorter than 10 characters', result.errorMsg, 'Incorrect message');
+            equal(result.errorMsg, 'The input value is shorter than 10 characters', 'Incorrect message');
 
         });