Required fields validation message

[Igloczek]

Don't you think that displaying "You have not answered all required fields" message on every type of input might be not so UX friendly? It looks weird when few text fields/checkboxes in row has that type of error.

IMO only radio buttons should use this type of msg, every other might have something like "This field is required".

[victorjonsson]

Yes, I agree. The error message "You have not answer...." is intended to be used when having all error messages displayed together upon form submit (using errorMessagePosition:"top"). Thus there must exist two different generic messages, one referring to a specific input and another one referring to the form submission.

As a quick fix you can override the requiredFields property in the language object.

$.validate({
   language: {
     requiredFields: "This field is required"
   }
});

[Igloczek]

Ok, I'll try to create pull request with this update.

[victorjonsson]

Sounds great. I think it will require some serious refactoring though... Maybe you would like to propose a possible solution before you implement it? This kind of change would require backwards compatibility. It's also important that the change caters to the idea of simplicity, it should not require programming skills to use the plugin (general knowledge about the web and html/js/css should be enough).

[Igloczek]

@victorjonsson Check if you like this solution - 6d804e8

[victorjonsson]

It's great! The only thing is that we don't have translations for requiredFields in all languages. Could you do a check that the property exists in the language object. Something like this

errorMessageKey: function(config) { 
      var useGeneralMessage = config.errorMessagePosition === 'top' || config.errorMessagePosition === 'custom';
      if ( useGeneralMessage && config.language['requiredFields'] ) {
        return 'requiredFields';
      }
      else {
        return 'requiredField';
      }
   }
}

It's important that you don't do a strict comparison on config.language['requiredFields'] in the if-statement. That way I can add the property to all language files with an empty string as value and a todo-comment stating that it needs to be translated, hoping that someone will pick it up and translate it eventually.

[Igloczek]

All missing translations added - big thanks for great translations packages to Magneto community!