Modernize the build/test, only assign to the old API in 3.x #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes: 1. Modernize the build/test infra: avoid the needless build, use jtr to run tests on real browsers, test browsers on CI. 2. Make the plugin not cause jQuery Migrate warnings due to assignment to the legacy API.
mgol
commented
May 4, 2025
src/jquery-deferred-reporter.js
Outdated
Comment on lines
28
to
41
| var version = jQuery.fn.jquery | ||
| .split( "." ) | ||
| .map( function( v ) { | ||
| return Number( v ); | ||
| } ); | ||
|
|
||
| // Only assign to the newer API if supported to avoid jQuery Migrate warnings. | ||
| if ( version[ 0 ] >= 4 || ( version[ 0 ] === 3 && version[ 1 ] >= 7 ) ) { | ||
| jQuery.Deferred.getErrorHook = getErrorHook; | ||
| } else { | ||
| jQuery.Deferred.getStackHook = getErrorHook; | ||
| } | ||
|
|
||
| return getErrorHook; |
There was a problem hiding this comment.
These changes can now mostly be reverted - or at least simplified - after jquery/jquery-migrate#577 & jquery/jquery-migrate#578.
Tests will need updates as well.
I'm considering assigning both in jQuery <4 and only the new API in jQuery >=4; that would be much shorter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
@dmethvin BTW, if you'd like, I'd be happy to help maintain this plugin. If you agree, could you give me write access?