TypeError: Cannot read properties of undefined (reading 'replace')

[armanozak]

First of all, thank you very much for this plugin. It has saved us a lot of time.

The cleanRuleRawsBefore function replaces multiple new lines from the before property of a node's raws, but results in a type error same as the title of this issue when the property is missing.

The error is caused by this line: https://github.com/elchininet/postcss-rtlcss/blob/master/src/utilities/rules.ts#L165

The following change fixes the error:

node.raws.before = '\n\n' + (node.raws.before ? node.raws.before.replace(/\n/g, '') : '');

Please let me know if you would like me to create a PR.

[elchininet]

Hi @armanozak, pull requests are always welcomed. But it would be good to know when this happens to write the appropriate tests to cover it. Do you know exactly in which cases is this property missing?

[armanozak]

Hi @elchininet,

Thanks for the quick response. The error appeared when we upgraded Tailwind from v1 to v3 and only on directional classes with responsive modifiers.

I have opened a PR. I saw the tests, but could not figure out how this change fits in the existing tests.

[elchininet]

Hey @armanozak, don't worry, just provide me with a minimum reproducible example of the issue, I'll check when and why it fails and I'll push the tests to your pull request.

Thanks!

[armanozak]

Hey @elchininet,

Here is a minimal reproduction of the issue: https://github.com/armanozak/repro-postcss-rtlcss-110

Thanks again!

[elchininet]

Perfect @armanozak, let it on my hands ;)
Thanks

[elchininet]

Hi @armanozak, it was impossible to create a test because it doesn‘t fail if the CSS is loaded directly from a file, it only fails if the CSS is built using tailwind, in these cases the rules built have an empty raws object. So, I‘ll merge the merge request (the tests are frozen for some reason) and try to make some tests of the method later to try to cover that case.

[armanozak]

Thank you @elchininet. Have a good evening.

[elchininet]

Hi @armanozak, your fix is contained in version 3.5.1 of the package. Regards and thanks for your contribution.