Skip to content

Add parameter 'pageview' (used on ep_page_view plugin)#20

Merged
JohnMcLear merged 3 commits intoether:masterfrom
lpagliari:master
Apr 17, 2015
Merged

Add parameter 'pageview' (used on ep_page_view plugin)#20
JohnMcLear merged 3 commits intoether:masterfrom
lpagliari:master

Conversation

@lpagliari
Copy link

No description provided.

@leandromoreira
Copy link

👍

1 similar comment
@storytouch
Copy link

👍

@JohnMcLear
Copy link
Member

There a thousands of possible url parameters exposed by plugins, I think at this point we should extend functionality to allow for a KV object that allows embedded params..

@JohnMcLear
Copy link
Member

Something like..

plugins:{
  pageview: false,
  realtimechat: false
}

Thoughts?

@lpagliari
Copy link
Author

@JohnMcLear Something like this?

$('#examplePadPlugins').pad({'padId':'test','plugins':{'pageview':'true'}});

@JohnMcLear
Copy link
Member

Yeah is that clean enough?
----- Reply message -----
From: "Luiza Pagliari" notifications@github.com
To: "ether/etherpad-lite-jquery-plugin" etherpad-lite-jquery-plugin@noreply.github.com
Cc: "John McLear" John@mclear.co
Subject: [etherpad-lite-jquery-plugin] Add parameter 'pageview' (used on ep_page_view plugin) (#20)
Date: Thu, Apr 16, 2015 23:09

@JohnMcLearhttps://github.com/JohnMcLear Something like this?

$('#examplePadPlugins').pad({'padId':'test',plugins:{'pageview':'true'}});


Reply to this email directly or view it on GitHubhttps://github.com//pull/20#issuecomment-93851037.

@lpagliari
Copy link
Author

Yep!

@lpagliari
Copy link
Author

Was that what you had in mind?

JohnMcLear added a commit that referenced this pull request Apr 17, 2015
Add parameter 'pageview' (used on ep_page_view plugin)
@JohnMcLear JohnMcLear merged commit 67df8d4 into ether:master Apr 17, 2015
@JohnMcLear
Copy link
Member

Yep! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants