support to only transform rules filtered by mediaQuery option #36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KODerFunk
requested changes
Oct 4, 2019
Member
KODerFunk
left a comment
There was a problem hiding this comment.
@silenaker good job! 👍
You need to make a few edits, and duplicate changes from README.md to README_CN.md.
| function validateParams(params, mediaQuery) { | ||
| if (Object.prototype.toString.call(mediaQuery) === '[object RegExp]') { | ||
| return mediaQuery.test(params) | ||
| } else if (Object.prototype.toString.call(mediaQuery) === '[object Array]') { |
Member
There was a problem hiding this comment.
Instead of Object.prototype.toString.call(mediaQuery) === '[object Array]' use:
Array.isArray(mediaQuery)
| } | ||
|
|
||
| function validateParams(params, mediaQuery) { | ||
| if (Object.prototype.toString.call(mediaQuery) === '[object RegExp]') { |
Member
There was a problem hiding this comment.
Instead of Object.prototype.toString.call(mediaQuery) === '[object RegExp]' use:
mediaQuery instanceof RegExp
| - `[/^body$/]` will match `body` but not `.body` | ||
| - `minPixelValue` (Number) Set the minimum pixel value to replace. | ||
| - `mediaQuery` (Boolean) Allow px to be converted in media queries. | ||
| - `mediaQuery` (Boolean or Regexp or Array) Allow px to be converted in media queries. |
Member
There was a problem hiding this comment.
...or Array of Regexp) Allow ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I only want to transform the px inside mobile media queries (e.g. max-width: 750px) when I have many media queries for responsive design, please support this feature