Skip to content

Commit 74ccbc1

Browse files
committed
Tabs: Rename ui-tab class to ui-tabs-tab for consistent prefixes
Fixes #12061 Closes jquerygh-1538 Ref #7053 Ref jquery/api.jqueryui.com#256
1 parent 1d193c2 commit 74ccbc1

File tree

2 files changed

+24
-3
lines changed

2 files changed

+24
-3
lines changed

tests/unit/tabs/core.js

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ var state = testHelper.state;
99
module( "tabs: core" );
1010

1111
test( "markup structure", function( assert ) {
12-
expect( 17 );
12+
expect( 20 );
1313
var element = $( "#tabs1" ).tabs(),
1414
tabList = element.find( "ul, ol" ),
1515
tabs = tabList.find( "li" ),
@@ -21,9 +21,15 @@ test( "markup structure", function( assert ) {
2121
assert.lacksClasses( element, "ui-tabs-collapsible" );
2222
assert.hasClasses( tabList, "ui-tabs-nav ui-widget-header" );
2323
equal( tabList.length, 1, "The widget contains exactly one tab list" );
24+
assert.hasClasses( tabs[ 0 ], "ui-tabs-tab" );
25+
assert.hasClasses( tabs[ 1 ], "ui-tabs-tab" );
26+
assert.hasClasses( tabs[ 2 ], "ui-tabs-tab" );
27+
28+
// DEPRECATED
2429
assert.hasClasses( tabs[ 0 ], "ui-tab" );
2530
assert.hasClasses( tabs[ 1 ], "ui-tab" );
2631
assert.hasClasses( tabs[ 2 ], "ui-tab" );
32+
2733
equal( tabs.length, 3, "There are exactly three tabs" );
2834
assert.hasClasses( anchors[ 0 ], "ui-tabs-anchor" );
2935
assert.hasClasses( anchors[ 1 ], "ui-tabs-anchor" );

ui/tabs.js

Lines changed: 17 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@
3232
}
3333
}( function( $ ) {
3434

35-
return $.widget( "ui.tabs", {
35+
$.widget( "ui.tabs", {
3636
version: "@VERSION",
3737
delay: 300,
3838
options: {
@@ -417,7 +417,7 @@ return $.widget( "ui.tabs", {
417417
role: "tab",
418418
tabIndex: -1
419419
} );
420-
this._addClass( this.tabs, "ui-tab", "ui-state-default" );
420+
this._addClass( this.tabs, "ui-tabs-tab", "ui-state-default" );
421421

422422
this.anchors = this.tabs.map( function() {
423423
return $( "a", this )[ 0 ];
@@ -880,4 +880,19 @@ return $.widget( "ui.tabs", {
880880
}
881881
} );
882882

883+
// DEPRECATED
884+
// TODO: Switch return back to widget declaration at top of file when this is removed
885+
if ( $.uiBackCompat !== false ) {
886+
887+
// Backcompat for ui-tab class (now ui-tabs-tab)
888+
$.widget( "ui.tabs", $.ui.tabs, {
889+
_processTabs: function() {
890+
this._superApply( arguments );
891+
this._addClass( this.tabs, "ui-tab" );
892+
}
893+
} );
894+
}
895+
896+
return $.ui.tabs;
897+
883898
} ) );

0 commit comments

Comments
 (0)