Skip to content

extract-css-chunks-webpack-plugin breaks in IE11 #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nirbhaymandelia opened this issue Jul 13, 2018 · 15 comments · Fixed by #85
Closed

extract-css-chunks-webpack-plugin breaks in IE11 #83

nirbhaymandelia opened this issue Jul 13, 2018 · 15 comments · Fixed by #85
Assignees
Labels

Comments

@nirbhaymandelia
Copy link

I have encounter an issue while using this plugin it breaks in Internet Explorer 11. further narrow down the problem the root cause is arrow function inside hotModuleReplacement.js right now hotModuleReplacement is not getting transpiled with babel causing this issue. could you please look into it.
I try out three versions 3.0.5, 3.0.6, 3.0.7 and issue exist in all the three version.

@ScriptedAlchemy
Copy link
Collaborator

Fixing now, thank you!

@ScriptedAlchemy ScriptedAlchemy self-assigned this Jul 13, 2018
ScriptedAlchemy added a commit that referenced this issue Jul 13, 2018
…arrow functions

Arrow functions break IE11 (whats new), updated eslint so it wont autofix it

fix #83
@ScriptedAlchemy
Copy link
Collaborator

#85

@ScriptedAlchemy
Copy link
Collaborator

Let me know if this solves it @nirbhaymandelia npm i extract-css-chunks-webpack-plugin@next

@nirbhaymandelia
Copy link
Author

nirbhaymandelia commented Jul 14, 2018

Still not able to, Now I see destructuring objects const { forEach } = Array.prototype; in line 7 causing problem.

@ScriptedAlchemy
Copy link
Collaborator

@nirbhaymandelia 3.0.8-beta.2 try that?

@kevinlaw91
Copy link
Contributor

Hi, i tested beta.2 and template literals are still causing issue.

@nirbhaymandelia
Copy link
Author

@ScriptedAlchemy
Copy link
Collaborator

Released beta.3, sorry that part came from someone else so i didnt think to check it!!
npm i extract-css-chunks-webpack-plugin@next

@ScriptedAlchemy
Copy link
Collaborator

Released beta.3, sorry that part came from someone else so i didn't think to check it!!
npm i extract-css-chunks-webpack-plugin@next

@kevinlaw91
Copy link
Contributor

Hi @ScriptedAlchemy I believe that you have fixed the wrong file. 😅
I have tested that the plugin will work after fixing template literals in L35, 37 and 68 of hotModuleReplacement.js. Btw, thanks for your great plugin.

@ScriptedAlchemy
Copy link
Collaborator

@kevinlaw91 Can you share your hotModuleReplacement.js file with me?

@ScriptedAlchemy
Copy link
Collaborator

ScriptedAlchemy commented Jul 16, 2018

Okay @kevinlaw91 @nirbhaymandelia I updated the next tag

Please, once more: npm i extract-css-chunks-webpack-plugin@next

Apologies for the back and forth on this one

@kevinlaw91
Copy link
Contributor

Error in hotLoader.js when running webpack build. You should revert the previous hotLoader.js fix

@ScriptedAlchemy
Copy link
Collaborator

ScriptedAlchemy commented Jul 16, 2018

Okay done and om NPM
@kevinlaw91

@kevinlaw91
Copy link
Contributor

👍 works great now on my side.

ScriptedAlchemy added a commit that referenced this issue Jul 16, 2018
…ws (#85)

* fix(.eslintrc,hotModuleReplacement.js): Update linting rules, remove arrow functions

Arrow functions break IE11 (whats new), updated eslint so it wont autofix it

fix #83

* style: Updated linting rules

No destructuring for IE

* fix: ES6 strings not TL

Dont use template literals
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants