HMR Not working on latest

[dmitrif]

Hi!

I yet again have yet to create a trimmed down example of the problem, but for now this is the issue.
We have HMR enabled (using the hot) parameter, however not seeing the hot-loader code being injected into any bundles. Therefore when an update is made, the style include is never reloaded.

What am I possibly missing?

Thanks.

[dmitrif]

Seems like the plugin has the following lines:

if (isHOT && compiler.options.module && compiler.options.module.rules) {
      const updatedRules = compiler.options.module.rules.reduce((rules, rule) => {
            if (rule.use && Array.isArray(rule.use)) {

However, when a console log is added, our compiler.options.module.rules looks like:

rules: [ { parser: [Object] }, { oneOf: [Array] } ]

This is due to how we are defining our loaders:

const jss = (isClient = true) => {
  const use = [];

  if (isClient) {
    const extractStyles = getExtractStyles();
    use.push(extractStyles.loader);
  }

  use.push({
    loader: require.resolve('@kijiji/jss-loader'),
    options: {
      localsOnly: !isClient,
      hot: !isClient && isDevMode,
      hashClassName: !isDevMode,
      plugins: [
        jssExtendPlugin,
        jssNestedPlugin,
        jssCamelCasePlugin,
        jssDefaultUnitPlugin,
        jssVendorPrefixerPlugin,
        jssRulePrefixerPlugin,
      ],
    },
  });

  use.push(getBabelLoader(isClient));

  return {
    test: /\.jss$/,
    exclude: [/node_modules\//],
    use,
  };
};

and then

rules: [
    disallowRequireEnsure,
    {
      oneOf: [jsx(), mjs, jss(), fonts, graphql, assets()],
    },
  ],```

[ScriptedAlchemy]

Hey, i see the issue here. Any chance you could make a small demo repo with your webpack config. or can you send me a stder output of your webpack JSON object.

Ill fix this but want to make sure i can see whats going on

Alternatively can you open a PR, seeing as you know the exact lines in my code that cause it to stop. IF you PR a working version, ill merge it! Otherwise ill need some more info from you

[dmitrif]

Damn, that's what I get for not checking github more often. Had a PR ready but seeing as you fixed it, thank you! <3

[dmitrif]

Although... I may still submit the PR since oneOf / use can be nested indefinitely from my understanding.

[ScriptedAlchemy]

Dude, if you can clean that up a bit --- ill totally accept the PR, thank you for working on it and i am sorry to have waisted your time.

Will gladly accept improvements to the plugin

[dmitrif]

#103 PR created :)

[faceyspacey]

🎉 This issue has been resolved in version 3.3.0 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀