Skip to content

[wip] feat: webpack 5 support #135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

pi0
Copy link

@pi0 pi0 commented Dec 22, 2018

Links:

Checklist:

@pi0 pi0 requested a review from ScriptedAlchemy as a code owner December 22, 2018 20:46
@pi0 pi0 mentioned this pull request Dec 22, 2018
22 tasks
@ScriptedAlchemy
Copy link
Collaborator

finally webpack 5 is out the door and the hooks api has been uplifted.

thanks for this. is there anything left that needs to be done? looks like webpack 4 integrity has been kept in tact

@ScriptedAlchemy
Copy link
Collaborator

ahh wait, i see you are still investigating the second half.

@ScriptedAlchemy
Copy link
Collaborator

I’ll also start looking into this. Will speak to my people at webpack

@ScriptedAlchemy
Copy link
Collaborator

Im going to pick this up, any ideas about this error @pi0

Module build failed (from ../../../extract-css-chunks-webpack-plugin/dist/loader.js):
TypeError: The 'compilation' argument must be an instance of Compilation
    at Function.getCompilationHooks (/Volumes/lulu_dev/extract-css-chunks-webpack-plugin/node_modules/webpack/lib/javascript/JavascriptModulesPlugin.js:116:10)
    at compiler.hooks.thisCompilation.tap.compilation (/Volumes/lulu_dev/extract-css-chunks-webpack-plugin/node_modules/webpack/lib/node/NodeTemplatePlugin.js:33:42)
    at Hook.eval [as call] (eval at create (/Volumes/lulu_dev/webpack-external-import/node_modules/webpack/node_modules/tapable/lib/HookCodeFactory.js:19:10), <anonymous>:7:1)

@pi0
Copy link
Author

pi0 commented Mar 13, 2020

@ScriptedAlchemy Sorry for missing your message was quite busy on other tasks. Thanks for picking this up ❤️ I will try to follow your works and help if possible.

@ScriptedAlchemy
Copy link
Collaborator

Supports webpack 5 now. I’ve been working on WP5 Core - I wrote Module Federation:)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants