fix: tests

package.json

@@ -47,7 +47,7 @@
     "prepublish": "npm run build",
     "release:validate": "commitlint --from=$(git describe --tags --abbrev=0) --to=$(git rev-parse HEAD)",
     "security": "npm audit",
-    "test": "jest",
+    "test": "jest --updateSnapshot",
     "test:watch": "jest --watch",
     "test:coverage": "jest --collectCoverageFrom='src/**/*.js' --coverage",
     "test:manual": "webpack-dev-server test/manual/src/index.js --open --config test/manual/webpack.config.js",
@@ -89,6 +89,7 @@
     "eslint": "^4.17.0",
     "eslint-plugin-import": "^2.8.0",
     "eslint-plugin-prettier": "^2.6.0",
+    "execa": "^1.0.0",
     "file-loader": "^1.1.11",
     "husky": "^0.14.3",
     "jest": "^22.2.2",

src/hmr/hotModuleReplacement.js

@@ -144,6 +144,7 @@ function reloadAll() {
 
 module.exports = function(moduleId, options) {
   if (noDocument) {
+    console.log('no window.document found, will not HMR CSS');
     return noop;
   }
 

src/index.js

@@ -394,21 +394,6 @@ class ExtractCssChunksPlugin {
     });
   }
 
-  traverseDepthFirst(root, visit) {
-    let nodesToVisit = [root];
-
-    while (nodesToVisit.length > 0) {
-      const currentNode = nodesToVisit.shift();
-
-      if (currentNode !== null && typeof currentNode === 'object') {
-        const children = Object.values(currentNode);
-        nodesToVisit = [...children, ...nodesToVisit];
-      }
-
-      visit(currentNode);
-    }
-  }
-
   getCssChunkObject(mainChunk) {
     const obj = {};
     for (const chunk of mainChunk.getAllAsyncChunks()) {

src/loader.js

@@ -12,8 +12,10 @@ import LimitChunkCountPlugin from 'webpack/lib/optimize/LimitChunkCountPlugin';
 const MODULE_TYPE = 'css/extract-css-chunks';
 const pluginName = 'extract-css-chunks-webpack-plugin';
 
-function hotLoader(content, context, modules) {
-  const accept = modules ? '' : 'module.hot.accept(undefined, cssReload);';
+function hotLoader(content, context) {
+  const accept = context.locals
+    ? ''
+    : 'module.hot.accept(undefined, cssReload);';
   const result = `${content}
     if(module.hot) {
       // ${Date.now()}

test/TestCases.test.js

@@ -1,8 +1,8 @@
 import fs from 'fs';
 import path from 'path';
-import { exec } from 'child_process';
 
 import webpack from 'webpack';
+import execa from 'execa';
 
 describe('TestCases', () => {
   const casesDirectory = path.resolve(__dirname, 'cases');
@@ -89,13 +89,12 @@ describe('HMR', () => {
   });
 
   it('is es5 only', () => {
-    exec(
-      './node_modules/.bin/es-check es5 src/hmr/hotModuleReplacement.js',
-      (error, stdout, stderr) => {
-        expect(
-          stderr.indexOf('there were no ES version matching errors!') > -1
-        ).toBe(true);
-      }
+    const { stderr } = execa.shellSync(
+      'npx es-check es5 src/hmr/hotModuleReplacement.js'
+    );
+
+    expect(stderr.indexOf('there were no ES version matching errors') > 1).toBe(
+      true
     );
   });
 });

test/__snapshots__/TestCases.test.js.snap

@@ -147,6 +147,7 @@ function reloadAll() {
 
 module.exports = function(moduleId, options) {
   if (noDocument) {
+    console.log('no window.document found, will not HMR CSS')
     return noop;
   }