This repository was archived by the owner on Jun 28, 2018. It is now read-only.
Add option to specify compression type. #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Sorry for my late reply. Thanks for this! |
faruken
added a commit
that referenced
this pull request
May 14, 2012
Add option to specify compression type.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I struggled with how to implement this. Initially I thought just having a single compression parameter would be best. It would have 3 possible values: True - compress with default 'x' compression, False - no compression, 'yui' - compress with YUI compressor. But then I thought that might be a little confusing so I decided to go with the second parameter.