compile method does not throw error

[icsaba]

the compile method does not throw an error in case of bad selectors are given.

const cssSelect = require('css-select');
cssSelect.compile("##button"); 

the compile method returns with a function, but an error expected Uncaught Error: Expected name, found ##button

The problem is with the css-what 's latest version where parser method does not throw the error.

[fb55]

This is a consequence of #18. Happy to take suggestions for a middle ground here.

[fb55]

Transferred the issue to the repo that would have to produce the error.

@icsaba css-what (and css-select) are currently more permissive than other CSS engines and would eg. find a <div id="#id"> with a ##id selector. It would be great if you could provide some context on how this is an issue.

[icsaba]

we use the compile method to validate css selectors given by the user, and after that we try to find the item in the DOM. (consider something like the browser's item selector) We provide an error if the selector is not valid, and stop the process, but if it says ##something is a valid selector, then neither the user nor we won't see anything on the UI / in the logs.

[fb55]

We now explicitly disallow names starting with #. Please let me know if there are other cases that should be covered.

[icsaba]

great, thank you