Skip to content

Use files property in package.json #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 22, 2015
Merged

Use files property in package.json #7

merged 1 commit into from
Jan 22, 2015

Conversation

kevva
Copy link
Contributor

@kevva kevva commented Jan 21, 2015

No description provided.

@shinnn
Copy link
Contributor

shinnn commented Jan 21, 2015

+1

test/out.json is over 250kb.

@shinnn shinnn mentioned this pull request Jan 21, 2015
fb55 added a commit that referenced this pull request Jan 22, 2015
Use `files` property in package.json
@fb55 fb55 merged commit 662b138 into fb55:master Jan 22, 2015
@fb55
Copy link
Owner

fb55 commented Jan 22, 2015

Thanks to both of you (also for #8)!

@shinnn
Copy link
Contributor

shinnn commented Jan 22, 2015

@fb55 No problem! I'd be glad if you release a new version :)

@fb55
Copy link
Owner

fb55 commented Jan 22, 2015

Apparently @npm has problems with the name again: npm/npm#4665. I can't publish a new version right now, but would be willing to switch the package to a lowercase name (if old references could be redirected).

cc @othiym23

@shinnn
Copy link
Contributor

shinnn commented Jan 22, 2015

Oh, I didn't know that problem.

@isaacs
Copy link

isaacs commented Jan 22, 2015

@fb55 Existing packages should be fine. You can push updates to them. you just can't create NEW packages with uppercase letters in the name, afaik.

If you want to lowecase it, you can soft-redirect with the npm deprecate command.

@fb55
Copy link
Owner

fb55 commented Jan 23, 2015

@isaacs This is the response I get:

feedy at feedy in ~/Documents/node_modules/CSSwhat on master [?]
$ npm pub
npm ERR! Darwin 14.0.0
npm ERR! argv "node" "/usr/local/bin/npm" "pub"
npm ERR! node v0.10.35
npm ERR! npm  v2.2.0

npm ERR! Invalid name: "CSSwhat"
npm ERR! 
npm ERR! If you need help, you may report this error at:
npm ERR!     <http://github.com/npm/npm/issues>

npm ERR! Please include the following file with any support request:
npm ERR!     /Users/feedy/Documents/node_modules/CSSwhat/npm-debug.log

edit: My point is that it doesn't seem to work; I'm aware that the log isn't especially helpful.

@isaacs
Copy link

isaacs commented Jan 23, 2015

@fb55 Yeah, I get it. I see, it's validating before sending to the registry. That feels like a reasonably-motivated idea that is unfortunately causing some unpleasant behavior in this case. We should be rejecting new package creation with uppercase names, but not updates to existing packages.

I'll bring it up with the team here.

@fb55
Copy link
Owner

fb55 commented Jan 24, 2015

Thanks @isaacs!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants