Skip to content

Conversation

@satazor
Copy link

@satazor satazor commented Feb 3, 2014

Also made some fixes to the coding style, e.g. there was places where spaces were being mixed with tabs.

There are two scroll situations that are not being handled:

  • scrollbar drag
  • mobile

The first one is really hard to do in a correct way. The later we could listen to touchstart/move events. Let me know if you want those handled, but I would say that for a initial version this is a good start.

This functionality will only work on jquery >= 1.8, not compromising lower versions.

@flesler flesler self-assigned this Feb 3, 2014
@satazor
Copy link
Author

satazor commented Feb 7, 2014

Bump!

@flesler
Copy link
Owner

flesler commented Feb 7, 2014

Yeah I know :(
It will take some time, sorry about that.

On Fri, Feb 7, 2014 at 3:57 PM, André Cruz notifications@github.com wrote:

Bump!


Reply to this email directly or view it on GitHubhttps://github.com//pull/69#issuecomment-34487965
.

Ariel Flesler

@satazor
Copy link
Author

satazor commented Mar 18, 2014

Bump!

@flesler
Copy link
Owner

flesler commented Mar 18, 2015

Hi @satazor, the part about supporting start, fail, etc callbacks is now possible since 2.0 #109.
As for the code to monitor user manual scrolling, I like the approach you linked to on StackOverflow better than actually listening for events.
I'll close this PR but will still work to push this change on #67 with the other approach.
Thanks!

@flesler flesler closed this Mar 18, 2015
@flesler
Copy link
Owner

flesler commented Mar 18, 2015

Correction: the link was provided by @westurner sorry

@flesler
Copy link
Owner

flesler commented Mar 18, 2015

This is implemented. To cancel on user scroll pass {interrupt:true}, if you want a callback that is called when the scroll is interrupted, you can pass a fail callback that is provided natively by jQuery. You can check the demo I updated it with an example of both settings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants