-
Notifications
You must be signed in to change notification settings - Fork 1k
Adds support for CommonJS / NPM #90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hi, thanks
I'm not a browserify user, it'd be great to have 1 or 2 more people check it works wen used for real. We had a couple of headaches with AMD support because people needed it in different ways and it broke existing calls. |
|
I've already published versions for 1.4.13 and .14 which failed (you can't force publish anymore in npm, let me know otherwise). You cannot register the name "jquery.scrollTo" (I believe it's because of the capital letter).
Old code, will remove / need to move quickly |
|
You should be able to unpublish, I also would like to publish using my user rather than yours so I can continue publishing new versions. "jquery.scrollto" seems good and is available. |
|
You can still publish if I add you as an owner :/ and feel free to publish as jquery.scrollto / do whatever you want :) |
|
I was asking you to edit the name on package.json so the PR is complete with no further commits frome me, and please set the version as 1.4.13 all over if you can. Thanks! |
|
(thumbsup) |
Adds support for CommonJS / NPM
|
Great, added a few tweaks, tested the demos and it seems to work well. |
|
Done, and thanks man! Appreciate it :) |
No description provided.