Skip to content

Conversation

@durango
Copy link
Contributor

@durango durango commented Jul 24, 2014

No description provided.

@flesler
Copy link
Owner

flesler commented Jul 24, 2014

Hi, thanks
I'd like a few changes if possible:

  • Bump to version 1.4.13 which is the next release
  • On NPM register as jquery.scrollTo which is available
  • What's this window.jQuery.fn.colorbox why are you setting it?

I'm not a browserify user, it'd be great to have 1 or 2 more people check it works wen used for real. We had a couple of headaches with AMD support because people needed it in different ways and it broke existing calls.

@durango
Copy link
Contributor Author

durango commented Jul 24, 2014

I've already published versions for 1.4.13 and .14 which failed (you can't force publish anymore in npm, let me know otherwise).

You cannot register the name "jquery.scrollTo" (I believe it's because of the capital letter).

window.jQuery.fn.colorbox

Old code, will remove / need to move quickly

@flesler
Copy link
Owner

flesler commented Jul 24, 2014

You should be able to unpublish, I also would like to publish using my user rather than yours so I can continue publishing new versions. "jquery.scrollto" seems good and is available.

@durango
Copy link
Contributor Author

durango commented Jul 24, 2014

You can still publish if I add you as an owner :/ and feel free to publish as jquery.scrollto / do whatever you want :)

@flesler
Copy link
Owner

flesler commented Jul 24, 2014

I was asking you to edit the name on package.json so the PR is complete with no further commits frome me, and please set the version as 1.4.13 all over if you can.

Thanks!

@durango
Copy link
Contributor Author

durango commented Jul 24, 2014

(thumbsup)

flesler added a commit that referenced this pull request Jul 24, 2014
Adds support for CommonJS / NPM
@flesler flesler merged commit 0be4aaa into flesler:master Jul 24, 2014
flesler added a commit that referenced this pull request Jul 24, 2014
@flesler
Copy link
Owner

flesler commented Jul 24, 2014

Great, added a few tweaks, tested the demos and it seems to work well.
I published to npm, could you unpublish jquery-scroll-to? it could lead people into a stagnant version of the plugin.
Thanks

@durango
Copy link
Contributor Author

durango commented Jul 24, 2014

Done, and thanks man! Appreciate it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants