Update jquery.scrollTo.js #98
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We really need this because when the `val` is `null` then condition returns `true` (because of `typeof null == 'object'`), and the `both` function returns `null` value which is set to `offset` variable. Later we have the following line flesler#118 `attr[key] += offset[pos] || 0;` and as the `offset` is `null` we get error message (totally sad face goes here).
Owner
|
I changed it to use jQuery.isPlainObject() just because that's what I expected the code to do. |
Author
|
the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We really need this because when the
valisnullthen condition returnstrue(because oftypeof null == 'object'), and thebothfunction returnsnullvalue which is set tooffsetvariable. Later we have the following line #118attr[key] += offset[pos] || 0;and as theoffsetisnullwe get error message (totally sad face goes here).