Skip to content

jQuery UI 1.9 compatibility #273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
fnagel opened this issue Oct 13, 2012 · 8 comments
Closed

jQuery UI 1.9 compatibility #273

fnagel opened this issue Oct 13, 2012 · 8 comments

Comments

@fnagel
Copy link
Owner

fnagel commented Oct 13, 2012

Any experience so far?

UPDATE:
confusion in this thread: UI 1.9 does NOT come with jQuery 1.9.x but with 1.8.x

@ghost ghost assigned fnagel Oct 13, 2012
@fnagel
Copy link
Owner Author

fnagel commented Nov 10, 2012

See #115 for Position redesign.

@last-partizan
Copy link

I'm using jquery-ui.selectmenu from your repo with jquery-1.9.1 and jquery-ui 1.10.0, it works, jquery-migrate show only one warning: "JQMIGRATE: jQuery.fn.attr('selected') may use property instead of attribute" for this code (line 275).

        this.element.find( 'option' ).each( function() {
            var opt = $( this );
            selectOptionData.push({
                value: opt.attr( 'value' ),
                text: self._formatText( opt.text(), opt ),
                selected: opt.attr( 'selected' ),
                disabled: opt.attr( 'disabled' ),
                classes: opt.attr( 'class' ),
                typeahead: opt.attr( 'typeahead'),
                parentOptGroup: opt.parent( 'optgroup' ),
                bgImage: o.bgImage.call( opt )
            });
        });

@fnagel
Copy link
Owner Author

fnagel commented Feb 5, 2013

Thanks for reporting! Are you aware how to fix this?

@last-partizan
Copy link

http://jquery.com/upgrade-guide/1.9/#attr-versus-prop-
I assume here attr can be replaced by prop for "selected"/"disabled" and maybe for "class".
This .prop('selected') and .prop('disabled') now returns boolean value and if your code depends on old behavior (attr returns string) it must be rewritten.

@fnagel
Copy link
Owner Author

fnagel commented Feb 8, 2013

I was aware of the newer prop method but I do not exactly know the difference to attr method. This is a good explanation: http://stackoverflow.com/a/5876747/991681

Any other issues with jQuery 1.9 and later UI version?

If you need a version working with the latest jQuery / UI you should test the jQuery UI Selectmenu branch (using jQuery 1.9 and jQuery UI 1.10.1pre): https://github.com/jquery/jquery-ui/tree/selectmenu

See here for more info #140

@last-partizan
Copy link

Don't noticed any other issues.

@fnagel
Copy link
Owner Author

fnagel commented May 6, 2013

Notice to myself: check this finally! Update for 1.10 needed!

@fnagel
Copy link
Owner Author

fnagel commented Sep 7, 2013

Selectmenu is now considered jQuery 1.8.x / jQuery UI 1.9.x ready.

@fnagel fnagel closed this as completed Sep 7, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants