Better image support (follow-up)#25
Conversation
…ons, then the value of the title attribute will be used as the URL for the image.
|
Did you recognize I added a background_image.html as a demo? I've never done anything collaborative, too -- so dont panic :-) Did you send the Pull request by using Git or by using GitHub (aka web based action)? |
|
Yes, I saw the new demo file. But I noticed the old one wasn't updated, so I fixed it. It would also be nice to link to the different demo pages from each other at some point so that it is easier for someone viewing live demos to see the other demos. |
|
Oh yeah. I did the pull request using github's web interface. Not sure how to do it any other way. |
|
Sorry for the late response but I focused my free time to work on a TYPO3 extension. Afaics these changes are already in the latest commit: 8bf0ec2 |
|
fnagel: I'm referring to the changes I made to default.html: |
|
As I already mentioned: |
|
@fnagel: Oh, I see what you mean. However, there are still background image demos in default.html in your repo, so I fixed them. Those demos should be removed from default.html. |
|
I will do this with the next commit. |
@fnagel:
Thanks for the background image updates. I've just fixed the demo file default.html so that it works as well.
I'm really new to using github, and I've never done anything collaborative yet. So if I did this Pull Request wrong, I apologize. My intent is for you to pull my changes in default.html to your fork.
Tauren