Skip to content

Better image support (follow-up)#25

Closed
tauren wants to merge 11 commits into
fnagel:selectmenufrom
tauren:selectmenu
Closed

Better image support (follow-up)#25
tauren wants to merge 11 commits into
fnagel:selectmenufrom
tauren:selectmenu

Conversation

@tauren
Copy link
Copy Markdown

@tauren tauren commented Oct 26, 2010

@fnagel:

Thanks for the background image updates. I've just fixed the demo file default.html so that it works as well.

I'm really new to using github, and I've never done anything collaborative yet. So if I did this Pull Request wrong, I apologize. My intent is for you to pull my changes in default.html to your fork.

Tauren

@fnagel
Copy link
Copy Markdown
Owner

fnagel commented Oct 26, 2010

Did you recognize I added a background_image.html as a demo?
http://github.com/fnagel/jquery-ui/blob/selectmenu/demos/selectmenu/background_image.html
I would prefer to show this functionality in a seperate file.

I've never done anything collaborative, too -- so dont panic :-) Did you send the Pull request by using Git or by using GitHub (aka web based action)?

@tauren
Copy link
Copy Markdown
Author

tauren commented Oct 27, 2010

Yes, I saw the new demo file. But I noticed the old one wasn't updated, so I fixed it. It would also be nice to link to the different demo pages from each other at some point so that it is easier for someone viewing live demos to see the other demos.

@tauren
Copy link
Copy Markdown
Author

tauren commented Oct 27, 2010

Oh yeah. I did the pull request using github's web interface. Not sure how to do it any other way.

@fnagel
Copy link
Copy Markdown
Owner

fnagel commented Nov 9, 2010

Sorry for the late response but I focused my free time to work on a TYPO3 extension.

Afaics these changes are already in the latest commit: 8bf0ec2

@tauren
Copy link
Copy Markdown
Author

tauren commented Nov 9, 2010

fnagel:

I'm referring to the changes I made to default.html:
tauren@8b966c3

@fnagel
Copy link
Copy Markdown
Owner

fnagel commented Nov 9, 2010

As I already mentioned:
I would prefer to show the background image functionality in a seperate file, not in default.html

@tauren
Copy link
Copy Markdown
Author

tauren commented Nov 9, 2010

@fnagel: Oh, I see what you mean. However, there are still background image demos in default.html in your repo, so I fixed them. Those demos should be removed from default.html.

@fnagel
Copy link
Copy Markdown
Owner

fnagel commented Nov 10, 2010

I will do this with the next commit.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants