Skip to content

feat: Support for Object syntax in custom callees beside classnames #185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
francoismassart merged 5 commits into from
Dec 13, 2022
Merged

feat: Support for Object syntax in custom callees beside classnames #185

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1214d00
feat: Classnames plugin handles key and value other way around
dipsaus9 Nov 30, 2022
faeb090
fix: Formatting
dipsaus9 Dec 1, 2022
791e847
feat: Also added sorting orders test
dipsaus9 Dec 1, 2022
ea60311
feat: Also added support for other rules
dipsaus9 Dec 1, 2022
5904634
Merge branch 'master' into master
francoismassart Dec 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
feat: Classnames plugin handles key and value other way around
  • Loading branch information
@dipsaus9
dipsaus9 committed Nov 30, 2022
commit 1214d003b216a3015c0181804ac5fe1e267a2694
10 changes: 9 additions & 1 deletion lib/util/ast.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,7 +209,15 @@ function parseNodeRecursive(node, arg, cb, skipConditional = false, isolate = fa
return;
case 'ObjectExpression':
arg.properties.forEach((prop) => {
parseNodeRecursive(node, prop.key, cb, skipConditional, forceIsolation);
const isUsedByClassNamesPlugin = node.callee && node.callee.name === 'classnames';

parseNodeRecursive(
node,
isUsedByClassNamesPlugin ? prop.key : prop.value,
cb,
skipConditional,
forceIsolation
);
});
return;
case 'Literal':
Expand Down
Loading