Skip to content

Variable Declarations & Callee Behavior #264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jd-carroll wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Variable Declarations & Callee Behavior #264

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
4b264d0
Vue specific names
jd-carroll Aug 11, 2023
443106b
Parse variable declarations
jd-carroll Aug 11, 2023
db6f424
Clean-up names
jd-carroll Aug 11, 2023
90a8f7f
Fix callee
jd-carroll Aug 11, 2023
84c9f49
Fix callee evaluation
jd-carroll Aug 11, 2023
ede49d0
Variable declarations on remaining rules && callee key vs value
jd-carroll Aug 11, 2023
d2ea041
Fix: Pass initialization node as arg
jd-carroll Aug 11, 2023
f1ab6f4
Support conditional expression declarations
jd-carroll Aug 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Support conditional expression declarations
  • Loading branch information
@jd-carroll
jd-carroll committed Aug 14, 2023
commit f1ab6f4f55f713697d9af459e5c31f2d1a8132a1
12 changes: 12 additions & 0 deletions lib/util/ast.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,6 +123,16 @@ function isObjectExpression(node) {
return node && node.type === 'ObjectExpression';
}

/**
* Find out if a node is an ConditionalExpression
*
* @param {ASTNode} node The AST node being checked
* @returns {Boolean}
*/
function isConditionalExpression(node) {
return node && node.type === 'ConditionalExpression';
}

/**
* Find out if node's value attribute is just simple text
*
Expand All @@ -134,6 +144,7 @@ function isValidDeclaratorValue(node) {
case isLiteralValue(node.init): // Simple string
case isArrayExpression(node.init): // ['tw-unknown-class']
case isObjectExpression(node.init): // {'tw-unknown-class': true}
case isConditionalExpression(node.init): // bool ? 'tw-unknown-class' : 'tw-unknown-class'
return true;
default:
return false;
Expand Down Expand Up @@ -432,6 +443,7 @@ module.exports = {
isLiteralValue,
isArrayExpression,
isObjectExpression,
isConditionalExpression,
isLiteralAttributeValue,
isValidDeclaratorValue,
isVArrayExpression,
Expand Down