Skip to content

No internal styles rule proposal #311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
georgyangelov wants to merge 2 commits into
base: master
Choose a base branch
from
Open

No internal styles rule proposal #311

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0efb69b
PoC for a no-internal-style rule
georgyangelov Jan 18, 2024
b201776
WIP on no-internal-style rule
georgyangelov Jan 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
PoC for a no-internal-style rule
  • Loading branch information
@georgyangelov
georgyangelov committed Jan 18, 2024
commit 0efb69b030454a75bd4b4a43a3cd783bf803d72e
40 changes: 40 additions & 0 deletions lib/config/groups.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,36 +46,44 @@ module.exports.groups = [
{
type: 'Columns',
members: 'columns\\-(?<value>${columns})',
internal: true,
},
{
type: 'Break After',
members: 'break\\-after\\-(?<value>auto|avoid|all|avoid\\-page|page|left|right|column)',
internal: true,
},
{
type: 'Break Before',
members: 'break\\-before\\-(?<value>auto|avoid|all|avoid\\-page|page|left|right|column)',
internal: true,
},
{
type: 'Break Inside',
members: 'break\\-inside\\-(?<value>auto|avoid|avoid\\-page|avoid\\-column)',
internal: true,
},
{
type: 'Box Decoration Break',
members: 'box\\-decoration\\-(?<value>clone|slice)',
internal: true,
},
{
type: 'Deprecated Box Decoration Break',
members: 'decoration\\-(?<value>clone|slice)',
deprecated: true,
internal: true,
},
{
type: 'Box Sizing',
members: 'box\\-(?<value>border|content)',
internal: true,
},
{
type: 'Display',
members:
'block|flex|grid|flow\\-root|contents|hidden|inline(\\-(block|flex|table|grid))?|table\\-(column|footer|header|row)\\-group|table(\\-(caption|row|cell|column))?|list\\-item',
internal: true,
},
{
type: 'Floats',
Expand All @@ -88,17 +96,21 @@ module.exports.groups = [
{
type: 'Isolation',
members: '(isolate|isolation\\-auto)',
internal: true,
},
{
type: 'Object Fit',
members: 'object\\-(?<value>contain|cover|fill|none|scale\\-down)',
internal: true,
},
{
type: 'Object Position',
members: 'object\\-(?<value>${objectPosition})',
internal: true,
},
{
type: 'Overflow',
internal: true,
members: [
{
type: 'overflow',
Expand All @@ -122,6 +134,7 @@ module.exports.groups = [
},
{
type: 'Overscroll Behavior',
internal: true,
members: [
{
type: 'overscroll',
Expand Down Expand Up @@ -214,10 +227,12 @@ module.exports.groups = [
{
type: 'Flex Direction',
members: 'flex\\-(row|col)(\\-reverse)?',
internal: true,
},
{
type: 'Flex Wrap',
members: 'flex\\-(wrap(\\-reverse)?|nowrap)',
internal: true,
},
{
type: 'Flex',
Expand Down Expand Up @@ -248,6 +263,7 @@ module.exports.groups = [
{
type: 'Grid Template Columns',
members: 'grid\\-cols\\-(?<value>${gridTemplateColumns})',
internal: true,
},
{
type: 'Grid Column Start / End',
Expand All @@ -269,6 +285,7 @@ module.exports.groups = [
{
type: 'Grid Template Rows',
members: 'grid\\-rows\\-(?<value>${gridTemplateRows})',
internal: true,
},
{
type: 'Grid Row Start / End',
Expand All @@ -290,17 +307,21 @@ module.exports.groups = [
{
type: 'Grid Auto Flow',
members: 'grid\\-flow\\-(dense|(row|col)(\\-dense)?)',
internal: true,
},
{
type: 'Grid Auto Columns',
members: 'auto\\-cols\\-(?<value>${gridAutoColumns})',
internal: true,
},
{
type: 'Grid Auto Rows',
members: 'auto\\-rows\\-(?<value>${gridAutoRows})',
internal: true,
},
{
type: 'Gap',
internal: true,
members: [
{
type: 'gap',
Expand All @@ -325,10 +346,12 @@ module.exports.groups = [
{
type: 'Justify Content',
members: 'justify\\-(start|end|center|between|around|evenly)',
internal: true,
},
{
type: 'Justify Items',
members: 'justify\\-items\\-(start|end|center|stretch)',
internal: true,
},
{
type: 'Justify Self',
Expand All @@ -337,10 +360,12 @@ module.exports.groups = [
{
type: 'Align Content',
members: 'content\\-(center|start|end|between|around|evenly|baseline)',
internal: true,
},
{
type: 'Align Items',
members: 'items\\-(start|end|center|baseline|stretch)',
internal: true,
},
{
type: 'Align Self',
Expand All @@ -349,10 +374,12 @@ module.exports.groups = [
{
type: 'Place Content',
members: 'place\\-content\\-(center|start|end|between|around|evenly|stretch|baseline)',
internal: true,
},
{
type: 'Place Items',
members: 'place\\-items\\-(start|end|center|stretch|baseline)',
internal: true,
},
{
type: 'Place Self',
Expand All @@ -365,6 +392,7 @@ module.exports.groups = [
members: [
{
type: 'Padding',
internal: true,
members: [
{
type: 'p',
Expand Down Expand Up @@ -459,6 +487,7 @@ module.exports.groups = [
},
{
type: 'Space Between',
internal: true,
members: [
{
type: 'space-y',
Expand Down Expand Up @@ -515,6 +544,7 @@ module.exports.groups = [
},
{
type: 'Typography',
internal: true,
members: [
{
type: 'Font Family',
Expand Down Expand Up @@ -626,6 +656,7 @@ module.exports.groups = [
},
{
type: 'Backgrounds',
internal: true,
members: [
{
type: 'Background Image URL',
Expand Down Expand Up @@ -854,6 +885,7 @@ module.exports.groups = [
},
{
type: 'Divide Width',
internal: true,
members: [
{
type: 'divide-y',
Expand All @@ -875,26 +907,32 @@ module.exports.groups = [
},
{
type: 'Divide Color',
internal: true,
members: 'divide\\-(?<value>${divideColor})',
},
{
type: 'Divide Style',
internal: true,
members: 'divide\\-(solid|dashed|dotted|double|none)',
},
{
type: 'Outline Width',
internal: true,
members: 'outline\\-(?<value>${outlineWidth})',
},
{
type: 'Outline Color',
internal: true,
members: 'outline\\-(?<value>${outlineColor})',
},
{
type: 'Outline Style',
internal: true,
members: 'outline(\\-(none|dashed|dotted|double|hidden))?',
},
{
type: 'Outline Offset',
internal: true,
members:
'(outline\\-offset\\-(?<value>${outlineOffset})|\\-outline\\-offset\\-(?<negativeValue>${-outlineOffset}))',
},
Expand Down Expand Up @@ -1047,6 +1085,7 @@ module.exports.groups = [
},
{
type: 'Tables',
internal: true,
members: [
{
type: 'Border Collapse',
Expand Down Expand Up @@ -1406,6 +1445,7 @@ module.exports.groups = [
},
{
type: 'Line Clamp',
internal: true,
members: 'line\\-clamp\\-(none|(?<value>${lineClamp}))',
},
],
Expand Down
2 changes: 2 additions & 0 deletions lib/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ module.exports = {
'no-arbitrary-value': require(base + 'no-arbitrary-value'),
'no-contradicting-classname': require(base + 'no-contradicting-classname'),
'no-custom-classname': require(base + 'no-custom-classname'),
'no-internal-style': require(base + 'no-internal-style'),
},
configs: {
recommended: {
Expand All @@ -36,6 +37,7 @@ module.exports = {
'tailwindcss/no-arbitrary-value': 'off',
'tailwindcss/no-custom-classname': 'warn',
'tailwindcss/no-contradicting-classname': 'error',
'tailwindcss/no-internal-style': 'off',
},
},
},
Expand Down
Loading