Skip to content

Add responsiveVariants to ignoredKeys by default #336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sushichan044 wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Add responsiveVariants to ignoredKeys by default #336

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6729e11
fix: ignore responsiveVariants key by default
sushichan044 Apr 25, 2024
1b4a62b
feat: add `responsiveVariants` to ignoredKeys by default
sushichan044 Apr 27, 2024
d52aa47
docs: update `ignoredKeys` doc
sushichan044 Apr 27, 2024
cbfef65
ci: add test for responsiveVariants
sushichan044 Apr 27, 2024
3dd63d9
docs: add comment on test
sushichan044 Apr 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
docs: add comment on test
  • Loading branch information
@sushichan044
sushichan044 committed Apr 27, 2024
commit 3dd63d9e7545035fb1de49a28d12792fd89fbefe
1 change: 1 addition & 0 deletions tests/lib/rules/no-custom-classname.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1545,6 +1545,7 @@ ruleTester.run("no-custom-classname", rule, {
callees: ["tv"],
},
],
// Before #323 is resolved, sm and md in responsiveVariants are also detected as Custom ClassName
errors: generateErrors("sushi"),
},
{
Expand Down