Skip to content

fix: no-arbitrary-value rule is too broad #342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
francoismassart merged 6 commits into from
Jun 6, 2024
Merged

fix: no-arbitrary-value rule is too broad #342

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
d1fcde1
fix: handle JSXNamespacedName
francoismassart Mar 21, 2024
6eb1ca5
3.15.2-beta.0
francoismassart Mar 21, 2024
7af882a
fix: no-arbitrary-value rule is too broad
francoismassart Mar 21, 2024
14a5003
3.15.2-beta.1
francoismassart Mar 21, 2024
4d516e0
Merge branch 'master' of github.com:francoismassart/eslint-plugin-tai…
francoismassart Jun 6, 2024
01f9e00
docs: changelog
francoismassart Jun 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: no-arbitrary-value rule is too broad
  • Loading branch information
@francoismassart
francoismassart committed Mar 21, 2024
commit 7af882aca918f09224a459d02b8340dd75215e33
2 changes: 1 addition & 1 deletion lib/rules/no-arbitrary-value.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,7 @@ module.exports = {
const forbidden = [];
classNames.forEach((cls, idx) => {
const parsed = groupUtil.parseClassname(cls, [], mergedConfig, idx);
if (/\[.*\]/i.test(parsed.name)) {
if (/\[.*\]/i.test(parsed.body)) {
forbidden.push(parsed.name);
}
});
Expand Down
3 changes: 3 additions & 0 deletions tests/lib/rules/no-arbitrary-value.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,9 @@ ruleTester.run("no-arbitrary-value", rule, {
code: `<div class="w-[10px]">Skip class attribute</div>`,
options: skipClassAttributeOptions,
},
{
code: `<div class="data-[state=open]:pb-8">Issue #318</div>`,
},
],

invalid: [
Expand Down