Skip to content

Performance gains on no-custom-classname and no-contradicting-classname #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
francoismassart merged 2 commits into from
Jul 12, 2021
Merged

Performance gains on no-custom-classname and no-contradicting-classname #42

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cc10743
feat: move file parsing & group generation out of hot code path
larrifax Jul 5, 2021
bb2c071
feat: move group generation out of hot code path
larrifax Jul 5, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
feat: move file parsing & group generation out of hot code path
  • Loading branch information
@larrifax
larrifax committed Jul 5, 2021
commit cc1074380fae5a8093d81a2174a0f156432a380e
7 changes: 4 additions & 3 deletions lib/rules/no-custom-classname.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,16 +74,17 @@ module.exports = {
// Helpers
//----------------------------------------------------------------------

// Init assets before sorting
const groups = groupUtil.getGroups(defaultGroups, mergedConfig);
const classnamesFromFiles = getClassnamesFromCSS(cssFiles);

/**
* Parse the classnames and report found conflicts
* @param {Array} classNames
* @param {ASTNode} node
*/
const parseForCustomClassNames = (classNames, node) => {
classNames = attrUtil.sanitizeClassnames(classNames);
// Init assets before sorting
const groups = groupUtil.getGroups(defaultGroups, mergedConfig);
const classnamesFromFiles = getClassnamesFromCSS(cssFiles);

classNames.forEach((className) => {
const idx = groupUtil.getGroupIndex(className, groups, mergedConfig.separator);
Expand Down