Skip to content

Refactor/speed improvement 2 #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
beaunus wants to merge 2 commits into from
Closed

Refactor/speed improvement 2 #93

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e93c6df
fix: compare new files properly with previousGlobsResults
beaunus Jan 11, 2022
2b88065
performance: only lookup globs if old ones are expired
beaunus Jan 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 18 additions & 16 deletions lib/util/cssFiles.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,25 +17,27 @@ let classnamesFromFiles = [];
*/
const generateClassnamesListSync = (patterns) => {
const now = new Date().getTime();
const files = fg.sync(patterns);
const newGlobs = previousGlobsResults.flat().join(',') != files.flat().join('');
const expired = now - lastUpdate > REFRESH_RATE;
if (newGlobs || expired) {
previousGlobsResults = files;
if (expired) {
lastUpdate = now;
let detectedClassnames = [];
for (const file of files) {
const data = fs.readFileSync(file, 'utf-8');
const root = postcss.parse(data);
root.walkRules((rule) => {
const regexp = /\.([^\.\,\s\n\:\(\)\[\]\'~\+\>\*\\]*)/gim;
const matches = [...rule.selector.matchAll(regexp)];
const classnames = matches.map((arr) => arr[1]);
detectedClassnames.push(...classnames);
});
detectedClassnames = removeDuplicatesFromArray(detectedClassnames);
const files = fg.sync(patterns);
const newGlobs = previousGlobsResults.flat().join(',') != files.flat().join(',');
if (newGlobs) {
previousGlobsResults = files;
let detectedClassnames = [];
for (const file of files) {
const data = fs.readFileSync(file, 'utf-8');
const root = postcss.parse(data);
root.walkRules((rule) => {
const regexp = /\.([^\.\,\s\n\:\(\)\[\]\'~\+\>\*\\]*)/gim;
const matches = [...rule.selector.matchAll(regexp)];
const classnames = matches.map((arr) => arr[1]);
detectedClassnames.push(...classnames);
});
detectedClassnames = removeDuplicatesFromArray(detectedClassnames);
}
classnamesFromFiles = detectedClassnames;
}
classnamesFromFiles = detectedClassnames;
}
return classnamesFromFiles;
};
Expand Down