Skip to content

Update test fixtures file names to @babel/helper-plugin-test-runner naming conventions #211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sthzg opened this issue Nov 19, 2018 · 1 comment · Fixed by #212
Closed

Update test fixtures file names to @babel/helper-plugin-test-runner naming conventions #211

sthzg opened this issue Nov 19, 2018 · 1 comment · Fixed by #212
Labels
released

Comments

@sthzg
Copy link
Contributor

sthzg commented Nov 19, 2018 •
edited
Loading

The beta versions of @babel/helper-plugin-test-runner specified the file names for automatic assertion to actual.js and expected.js, see README of beta version.

In the stable release this seems to have been changed to input.js and output.js, so that the current test suite seems to produce false positives (and not performing the actual assertions against expected.js).
sthzg pushed a commit to sthzg/babel-plugin-react-css-modules that referenced this issue Nov 19, 2018
@s24sherzog
fix: update test fixtures
d5516a2 
Fixes gajus#211
sthzg pushed a commit to sthzg/babel-plugin-react-css-modules that referenced this issue Nov 19, 2018
@s24sherzog
fix: update test fixtures
482ff9e 
Fixes gajus#211
@sthzg sthzg mentioned this issue Nov 19, 2018
Merged
gajus pushed a commit that referenced this issue Nov 19, 2018
@sthzg @gajus
fix: update test fixtures (#212)
ffcd14d 
* fix: update test fixtures

Fixes #211

* chore: assert exception on use with missing import
@gajus
Copy link
Owner

gajus commented Nov 19, 2018

🎉 This issue has been resolved in version 3.4.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

@gajus gajus added the released label Nov 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: update test fixtures sthzg/babel-plugin-react-css-modules
2 participants
@gajus @sthzg