Skip to content

Feature: having postcss syntax configurable #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Jan 6, 2017
Merged

Feature: having postcss syntax configurable #10

merged 12 commits into from
Jan 6, 2017

Conversation

jcdekoning
Copy link
Contributor

This PR makes it possible to configure the different postcss syntax parsers externally. This way the different parsers are not hardcoded and is it possible to add new syntax parsers without making code changes.

This was referenced Dec 9, 2016
@gajus
Copy link
Owner

gajus commented Dec 22, 2016

Hi @jcdekoning could you add documentation for these changes too?

PCreations and others added 7 commits December 24, 2016 19:35
…#13 #14 #17) (#12)

* fix: added escape hatch when testing attribute that do not have a name property (#11)

* fix: object expression generated on dynamic resolution now use quote to escape properties' name (#14)

* fix: getClassName now works as expected when multiple file use runtime resolution

* fix: getClassName now works as expected when multiple file use runtime resolution
* fix: added escape hatch when testing attribute that do not have a name property (#11)

* fix: object expression generated on dynamic resolution now use quote to escape properties' name (#14)

* fix: getClassName now works as expected when multiple file use runtime resolution

* fix: getClassName now works as expected when multiple file use runtime resolution

* fix: className attribute is now correctly generated when using runtime resolution (#18)
@jcdekoning
Copy link
Contributor Author

jcdekoning commented Dec 25, 2016

@gajus Updated the configuration section of the readme file to explain how to add support for other postcss syntax loaders

On a second though I realise that this change is breaking current installations which are using scss. Maybe adding a note and increase the version number as a major update avoids that these installations will break.

@gajus gajus merged commit f343ab1 into gajus:master Jan 6, 2017
@gajus
Copy link
Owner

gajus commented Jan 6, 2017

Thank you! v2 has been released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants