Support for extra postcss plugins #100
Conversation
src/requireCssModule.js
Outdated
| const getTokens = (runner, cssSourceFilePath: string, filetypes): StyleModuleMapType => { | ||
| type FileTypeOptions = {| | ||
| syntax: string, | ||
| plugins: Array<string> |
There was a problem hiding this comment.
Please use $ReadOnlyArray and covariant props, i.e. {|+syntax: string, plugins: $ReadOnlyArray<string>|}
src/requireCssModule.js
Outdated
| plugins: Array<string> | ||
| |}; | ||
|
|
||
| const getFiletypeOptions = (cssSourceFilePath: string, filetypes: Object): ?(string|FileTypeOptions) => { |
There was a problem hiding this comment.
filetypes type needs to be {[key: string]: FileTypeOptions}
There was a problem hiding this comment.
?(string|FileTypeOptions) does not match the return type (not getting an error here?) FileTypeOptions | string | null.
Where does the string come from, though?
There was a problem hiding this comment.
Where does the string come from, though?
I see.
Lets remove the shortcut. This is going to be a breaking change.
Require that FileTypeOptions is always present.
src/requireCssModule.js
Outdated
| return filetype; | ||
| }; | ||
|
|
||
| const getSyntax = (filetypeOptions: ?(string|FileTypeOptions)) => { |
There was a problem hiding this comment.
Require that filetypeOptions is always FileTypeOptions. Do not call getSyntax if filetypeOptions option is void.
src/requireCssModule.js
Outdated
| return null; | ||
| }; | ||
|
|
||
| const getExtraPlugins = (filetypeOptions: ?(string|FileTypeOptions)): Array<any> => { |
src/requireCssModule.js
Outdated
| return filetype; | ||
| }; | ||
|
|
||
| const getSyntax = (filetypeOptions: ?(string|FileTypeOptions)) => { |
There was a problem hiding this comment.
Declare the return type annotation for getSyntax.
| @@ -5,7 +5,9 @@ | |||
| { | |||
| "generateScopedName": "[name]__[local]", | |||
| "filetypes": { | |||
| ".less": "postcss-less" | |||
| ".less": { | |||
| "syntax": "postcss-less" | |||
There was a problem hiding this comment.
I've changed it to Object { "syntax": "..." }. Sorry, what's wrong?
There was a problem hiding this comment.
Oops. Sorry. This PR was the first thing I looked at this morning. :-)
|
So. What's next? I've updated the code according to your requests. |
Sorry, overloaded at work. Merged. Thank you, |
|
Is there any way to set options on the plugins loaded this way? |
Added support for extra postcss plugins. They can be specified in
"filetypes"section of config like this: