Prevent output file content changes between compiles #101
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
huh, using Thank you for the PR. Ping me when it is ready to merge. |
d0048a9 to
b435517
Compare
|
@gajus Done. I removed the line/column part as a single "anonymous" import is allowed anyway and there should not be name clashes in style map. |
|
Thank you |
NE-SmallTown
added a commit
to NE-SmallTown/babel-plugin-react-css-modules
that referenced
this pull request
Sep 9, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When this plugin is used, output content is changed between compiles as it uses random number in output when import is used without assign to variable (
import "./style.css";). This causes output file hash changes between builds having equal input and long-term asset caching for web is not working.My guess the random is used to identify imports so I replaced random with style file name and it's location in source to prevent clashes when the same file is imported multiple times (not sure if such case exists though).
Let me know if this is ok, I'm gonna adjust code style to your needs and add tests.
I guess the
process.env.NODE_ENV === 'test'conditional and it's contents can be removed as well asstyleImportNamewon't change anymore between tests?