Skip to content

Fix the ajv-keywords "keyword select requires $data option" warning. #116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 15, 2017

Conversation

trevorsmith
Copy link
Contributor

Fixes #111.

@the-spyke
Copy link

There is another issue:

npm WARN ajv-keywords@2.1.0 requires a peer of ajv@>=5.0.0 but none was installed.

But is package.json I see:

"dependencies": {
    "ajv": "^4.11.4",

@the-spyke
Copy link

@trevorsmith Could you try to replace $data: with '$data': and check if build is still failing?

@trevorsmith
Copy link
Contributor Author

Sorry for the delay, I've been out of town for the weekend.

There are two conflicting linting rules, both of which result in errors:

{ $data: true } // id-match - Identifier '$data' does not match the pattern
{ '$data': true } // quote-props - Unnecessarily quoted property '$data' found

I've added an inline comment to disable id-match.

@trevorsmith
Copy link
Contributor Author

I've also upgraded ajv to ^5.0.0 after looking over the changelog for any changes that might affect the options schema.

@gajus gajus merged commit 24fd47c into gajus:master Aug 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants