Update to https repo URL

[ArashMotamedi]

The non-secure SSH github url issues a security warning and requests the user to verify the server IP and key before proceeding with the clone. Using the https URL eliminates the warning.

[aikar]

um, this is a very bad change.

SSH is much more preferred than https for most people.
Are you talking about the absolutely normal, warning that its your first time connecting to github.com SSH message?

This is normal to accept that warning on first clone to github.

That only happens your first time, and you're effectively trading a once in a lifetime prompt for a prompt-every-time password prompt.

[ArashMotamedi]

My suggestion is in line with Github's own recommended cloning approach: https://help.github.com/articles/which-remote-url-should-i-use/

And my motivation for making this recommendation was that as rookie git user on Windows, when I issued git clone {ssh-url} I was asked to verify the authenticity of the remote server, which was an unfamiliar message for me.

Whereas the https url seemed more familiar (and similar to clone instructions of other repos I'd encountered before) and did not require me to verify host authenticity.

[aikar]

Yes https does have benefit in that it doesn't require the user to have a key on file just to clone public repos, but this really only affects first timers, and is usually a good poke and prod to get them to finish setting up their account.

So normally, repo's don't really need to worry about that detail. Github of course has to be "politically correct" and push the more "likely to not run into an error" approach.

I guess though since this is the 'demo instructions', https seems fine for that case (since also didn't consider that public repos aren't going to ask for authorization, just I never use https :P)