Skip to content

added more information to an error message #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

CurtisHumphrey
Copy link
Contributor

No description provided.

@gajus
Copy link
Owner

gajus commented Mar 9, 2017

Generally, I am against providing details in an error. This is a client side application. If error is happening while you are developing the application, use the devtools to inspect the state.

However, if we do provide details, then I'd rather do it in a console.log. I have updated the PR. Please tell me if this approach is good with you.

@CurtisHumphrey
Copy link
Contributor Author

CurtisHumphrey commented Mar 9, 2017

I'll have to check to see if that works. I have had issues with console.log being eaten by babel plugins whereas the error thrown always works and works well in test suites...

@jjinux
Copy link
Contributor

jjinux commented Apr 19, 2018

See: #179

@CurtisHumphrey
Copy link
Contributor Author

I think #179 solves what I was after.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants