Remove styles from props after render #103
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removing `styles` from `this.props` after render, in order not to hurt pure rendering logic.
If `this.props.styles` will remain, then shallow comparing props to newly received props will always return false.
(since even if nothing changed, the current props will have `styles: { ... }` and the new props will have `styles: undefined`;
gajus
added a commit
that referenced
this pull request
Mar 13, 2016
Remove styles from props after render
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing
stylesfromthis.propsafter render, in order not to hurt pure rendering logic.If
this.props.styleswill remain, then shallow comparing props to newly received props will always return false.(since even if nothing changed, the current props will have
styles: { ... }and the new props will havestyles: undefined)resolves #102