Remove lodash dependency #173
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey there,
I noticed you had done some work recently to reduce the bundle size incurred by using lodash, so I went ahead and pulled all of it out.
Here's what I did:
utils.js
with IE8-compatible implementations ofisFunction()
,isArray()
andisObject()
._.isFunction()
,_.isArray()
and_.isObject()
with those implementations._.assign()
withObject.assign()
and addedbabel-plugin-transform-object-assign
to maintain IE8 compatibility with_.assign()
._.isUndefined(map[key])
with(!(key in map))
._.forEach(obj)
withfor(const key in obj)
._.trim()
with atrim()
implementation that usesstr.trim()
or a regex if it's not there for IE8 support._.filter()
with afilterForTruthy()
function.If you don't care about IE8 support, let me know because a lot of the code here is for IE8 support.
Thanks!