Fixed insufficient splitting of styleName attribute content #226
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently it is impossible to use delimiters in styleName other than a single space symbol. The change allows to use any whitespace characters, such as a newline character which is handy if you use multiple class names in a single styleName attribute combined with ES6 string literal.
Motivation
We are using BEM along with
react-css-modules(because we are not yet decided if we are ready to abandon BEM in favor of CSS Modules). So we have multiple and pretty long string in styleName and ES6 string literal come to rescue here because it allows to write it multiline (also string templates make it easier to write modifiers). Unfortunately we can't use this nifty feature, because the styleName parser recognizes a newline character as a part of a class name which leads to conflicts between code and stylesheets thus we have to write styleName strings of hundreds colons wide.