Do not change keys on children. Fixes #237 #242
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When multiple children are provided right now they are mapped through
React.Children.mapwhich changes keys fromfooto.$foo. With complex re-renders I've encountered situations where the key changes with each re-render of the parent component so it starts withfoo->.$foo->.$.$fooetc, which results in that child component being re-mounted with each re-render and loose it's internal state.This PR changes
React.Children.maptoReact.Children.forEachwhich doesn't mess with the keys, while leaving the othermap's functionality intact.