Optimize linkArray by replacing elements in original array
#244
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Thank you for the quick merge! Could you please publish it to npm? |
Owner
It is automatically published every time I merge a PR. |
Contributor
Author
|
Hm. Weird. Looks like it didn't work this time. If you look here it still uses Looks like only previous PR triggered auto-release which published version |
gajus
added a commit
that referenced
this pull request
Jul 4, 2017
Owner
|
It probably did not like my "perf:" prefix. Made another commit to force the release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've found a way of optimizing
linkArraymethod that can avoid big performance hit(especially for gc). We really only need to replace elements in original array instead of creating new arrays withmap. I think that non-purity is not an issue in this case.