rendering <noscript> in case of rendering to null #25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
For documentation purposes, this behaviour is described in the v0.11 release notes. https://facebook.github.io/react/blog/2014/07/17/react-v0.11.html#rendering-to-null |
gajus
added a commit
that referenced
this pull request
Sep 17, 2015
rendering <noscript> in case of rendering to null
Owner
|
@goncalvesjoao very cool. I wish every PR was as thorough as this. 👍 Will release a version bump in a couple of minutes. |
Contributor
Author
|
thanks ^_^ |
Owner
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @gajus first of all, thank you so much for all the work!
I've stumbled upon an error on my app when I started using CSSModules(MyComponent, styles) to render certain Components that given certain conditions would return null, when rendering.
Made some changes to the "src/index.js" file, according to what React 0.11 did for the "Rendering to null" case.
Made some tests too.