Merge thousandsStay setting pull requests#1
Merged
gbass84 merged 8 commits intogbass84:masterfrom Nov 6, 2014
Merged
Conversation
Set default prefix to "US$ " and default affixStay to "false". Added thousandsStay setting with default value of "false".
Changed prefix, affixesStay, and thousandsStay default values from personalized to more general purpose settings.
Replaced ALL occurrences of the thousands symbol using a global regexp.
Owner
|
Sounds good. I had somehow missed this. I'll merge this this afternoon or evening. |
gbass84
added a commit
that referenced
this pull request
Nov 6, 2014
Merge thousandsStay setting pull requests
Owner
|
sorry that took so long, my IDE mangled the whitespace and made it unable to merge, I tried to resolve through a couple different methods, but in the end decided to just wholesale copy your version in so it would merge and we can just move on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We should consolidate our efforts, I'll close my pull request and we can focus on yours. I've updated the README.md here to document the new setting.