Additional nesting issue fixes - #64
Open
kevnk wants to merge 1 commit into
Open
Conversation
kevnk
referenced
this pull request
in kevnk/csstyle
Jan 19, 2016
I was having additional issues to the ones described in issue geddski#58 for the following: ```html <div class="Component"> <div class="Component__ParentPart --ShowChild"> <div class="Component__ChildPart">Show me when my parent has --ShowChild option</div> </div> </div> ``` ```scss @include component(Component) { @include part(ChildPart) { display: none; } @include part(ParentPart) { @include option(ShowChild) { @include part(ChildPart) { display: block; } } } } ``` Before the committed changes, the above compiled to: ```css .Component__ChildPart { display: none; } .Component__ParentPart.\--ShowChild__ChildPart { display: block; } ``` Now, after these committed changes, it compiles to: ```css .Component__ChildPart { display: none; } .Component__ParentPart.\--ShowChild .Component__ChildPart { display: block; } ```
|
I'm still seeing this problem in v1.5.1. Is there a reason this PR can't be merged? It seems to solve the problem well |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was having additional issues to the ones described in issue #58 for the following:
Before the committed changes, the above compiled to:
Now, after these committed changes, it compiles to: