Skip to content

Fix bundle (closes #5) #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix bundle (closes #5) #8

wants to merge 1 commit into from

Conversation

oligot
Copy link

@oligot oligot commented Dec 18, 2015

This fixes the bundle by exporting the bundle function.

Successfully tested with https://github.com/css-modules/jspm-demo

@oligot
Copy link
Author

oligot commented Dec 30, 2015

@geelen Is there anything I can do on my side so that this PR can be merged ?

@juliogarciag
Copy link

@geelen I hate to use +1s but 👍 It would be cool if this is merged :)

@conundrumer
Copy link

+1

@Karsten-Goetz
Copy link

Hello, are you still working on this project? I tried the available demos and can't get the bundling / build-process to work. I tried the fix from @oligot, too. Has someone the plugin in a working example today - just to know if bundle/build is working or not? Thank you, if you have some tipps - very welcome! It would be great to get this cool stuff running...

@komachi
Copy link

komachi commented Dec 5, 2016

@Karsten-Goetz I got this working with appending that fix, and two fixes for jspm-loader-css: geelen/jspm-loader-css#52 and geelen/jspm-loader-css#41 (merged, but missing npm release). Hope this will be fixed, as having fork to get this work is a not a nice way.

@mribichich
Copy link

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants