Added an option to sort the result set by min distance#22
Closed
joshpangell wants to merge 1 commit intogilmoreorless:masterfrom
Closed
Added an option to sort the result set by min distance#22joshpangell wants to merge 1 commit intogilmoreorless:masterfrom
joshpangell wants to merge 1 commit intogilmoreorless:masterfrom
Conversation
Owner
|
Hi, thanks for this PR, I like the idea. :) A couple of things though:
Cheers, |
Owner
|
Closing this in favour of the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@gilmoreorless's wonderful plugin does a great job of finding the nearest elements. However, I was missing the ability to find the nearest elements sorted in order of proximity nearest to furthest. The current result set it in order of DOM tree. I had posted this as an issue here, but have gone ahead and made a fix for it instead.
This simple change adds the option
sortMinDistto receive the result set ordered nearest to furthest. Here is a fiddle to see the update in action.Usage: