Skip to content

Rewrite the build process in Grunt 0.4.5, use jQuery & QUnit from npm #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

mgol
Copy link
Collaborator

@mgol mgol commented Mar 16, 2016

Also, update the QUnit syntax to the new API not relying on globals.

cc @gnarf

@mgol
Copy link
Collaborator Author

mgol commented Jul 25, 2016

@gnarf ping

@gnarf
Copy link
Owner

gnarf commented Jul 25, 2016

LGTM!

Also, update the QUnit syntax to the new API not relying on globals.
@mgol mgol closed this in 0fcd76b Oct 19, 2016
@mgol mgol deleted the build-rewrite branch October 19, 2016 13:20
@mgol
Copy link
Collaborator Author

mgol commented Oct 19, 2016

@gnarf Can I tag 0.2.0? Changing all -pre references to that version & tagging it is enough, isn't it? Is this package published somewhere or does it only have tags in the repo and that's it?

@gnarf
Copy link
Owner

gnarf commented Oct 19, 2016

yeah - it hadn't been published anywhere I don't think

@gnarf
Copy link
Owner

gnarf commented Oct 19, 2016

Release Notes in README, and feel free to publish to npm (just remember to add me to the publishers ;))

@mgol
Copy link
Collaborator Author

mgol commented Oct 19, 2016

To publish to npm we'll need to change the name in package.json - uppercase letters have not been allowed in names of new packages for some time.

@gnarf
Copy link
Owner

gnarf commented Oct 19, 2016

yeah - we should do that anyway...

Since it hadn't been published, I don't think I see any problems with this

@mgol
Copy link
Collaborator Author

mgol commented Oct 26, 2016

The package is on npm: https://www.npmjs.com/package/jquery.requestanimationframe

I made some mistakes in updating the README & version updates (leaving -pre & old versions here & there) so I released 0.2.1 & 0.2.2 after 0.2.0 (oops). It'd be good to automate that part one day.

I added you as a co-owner.

I also switched from JSHint to ESLint to follow what jQuery Core did.

@gnarf
Copy link
Owner

gnarf commented Nov 4, 2016

😘 thanks so much for updating all of this @mgol !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants