Skip to content
This repository was archived by the owner on Nov 27, 2018. It is now read-only.

Allow short-circuiting#14

Closed
andrewluetgers wants to merge 2 commits intogromo:masterfrom
andrewluetgers:master
Closed

Allow short-circuiting#14
andrewluetgers wants to merge 2 commits intogromo:masterfrom
andrewluetgers:master

Conversation

@andrewluetgers
Copy link

Added support via the new option allowOverlayBars to disable the plugin when OS bars overlay the content. This corresponds with how most modern browsers handle scrollbars, it is often the effect you are going for when you use this plugin and if its already acceptable why run this code. Now you don't have to.

Added support via the new option allowOverlayBars to disable the plugin when OS bars overlay the content. This corresponds with how most modern browsers handle scrollbars, it is often the effect you are going for when you use this plugin and if its already acceptable why run this code. Now you don't have to.
@gromo
Copy link
Owner

gromo commented Nov 6, 2014

Hi Andrew.

Thank You for your commit and your idea. I'm going to use existing function getBrowserScrollSize for detecting if native scrollbar overlays content - it will take only 2 rows to change in current script. Currently I'm working on hiding of native scrollbar in such cases, but your idea is great.

Thank You again.

@gromo
Copy link
Owner

gromo commented Nov 6, 2014

I was thinking about your changes. If I understood correctly, this option is used to avoid using custom scrollbar if native scrollbars overlay content - on mobile devices, and under Mac OS (maybe Linux too). Correct?

@andrewluetgers
Copy link
Author

Yes that is the idea. Be careful to test properly using getBrowserScrollSize, I tried that already and it did not cover my use case. Specifically with MacOS if you go to System Preferences > General and set Show Scroll Bars to Always, reloading the page should show custom scrollbars. Switching it to "Only when scrolling" should show native scrollbars. In light of this I also think the code to return a size of 0 for webkit becomes an issue. https://github.com/gromo/jquery.scrollbar/blob/master/jquery.scrollbar.js#L674
But yeah I agree probably should be able to do this with existing code.

@gromo
Copy link
Owner

gromo commented Nov 7, 2014

Hi Andrew. Can I contact you by email, skype or any other way?

@andrewluetgers
Copy link
Author

andrew dot lutegers at gmail
could email or gtalk

@gromo gromo closed this Nov 19, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments