Fix for Incompatible units when unitless value of 0#1
Open
groovenectar wants to merge 1 commit intomasterfrom
Open
Fix for Incompatible units when unitless value of 0#1groovenectar wants to merge 1 commit intomasterfrom
groovenectar wants to merge 1 commit intomasterfrom
Conversation
Only added px and % as cases to fix a particular app error, in case there are some edge case units that would break things. Should probably also include many others, if not all. If it should be all, then the last part of the new `if` statement where it checks the unit can be removed. Since I am not sure, I'm limiting the unit possibilities.
Hopefully this is the right place for this patch.
Getting this error:
/* Incompatible units: "px" and "".: line: 76 */
In this SCSS where the other value is computed to px:
$padding-value: max($padding - $outline-width, 0);
Making it "0px" in the SCSS fixes the error, but I don't think it should be throwing an error at all...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only added px and % as cases to fix a particular app error, in case there are some edge case units that would break things. Should probably also include many others, if not all. If it should be all, then the last part of the new
ifstatement where it checks the unit can be removed. Since I am not sure, I'm limiting the unit possibilities.Hopefully this is the right place for this patch.
Getting this error:
In this SCSS where the other value is computed to px:
Making it "0px" in the SCSS fixes the error, but I don't think it should be throwing an error at all...